Browse Source

feat(AdvancedTable): Minor tweaks

Owen Diffey 3 years ago
parent
commit
7e63e524c9
1 changed files with 23 additions and 29 deletions
  1. 23 29
      frontend/src/components/AdvancedTable.vue

+ 23 - 29
frontend/src/components/AdvancedTable.vue

@@ -96,6 +96,7 @@
 									'item-draggable': column.draggable,
 									'nav-item': true
 								}"
+								@click.prevent="toggleColumnVisibility(column)"
 							>
 								<p class="control is-expanded checkbox-control">
 									<label class="switch">
@@ -158,6 +159,20 @@
 									<span>
 										{{ column.displayName }}
 									</span>
+									<span
+										v-if="column.draggable"
+										content="Toggle Pinned Column"
+										v-tippy
+									>
+										<span
+											:class="{
+												'material-icons': true,
+												active: false
+											}"
+										>
+											push_pin
+										</span>
+									</span>
 									<span
 										v-if="column.sortable"
 										:content="`Sort by ${column.displayName}`"
@@ -191,34 +206,6 @@
 											expand_less
 										</span>
 									</span>
-									<span
-										v-if="column.draggable"
-										content="Toggle Pinned Column"
-										v-tippy
-									>
-										<span
-											:class="{
-												'material-icons': true,
-												active: false
-											}"
-										>
-											push_pin
-										</span>
-									</span>
-									<span
-										v-if="column.hidable"
-										content="Hide Column"
-										v-tippy
-									>
-										<span
-											@click="
-												toggleColumnVisibility(column)
-											"
-											class="material-icons"
-										>
-											visibility_off
-										</span>
-									</span>
 								</div>
 							</th>
 						</template>
@@ -581,9 +568,14 @@ export default {
 			&:hover,
 			&:focus,
 			&.highlighted {
-				background-color: var(--dark-grey);
+				background-color: var(--dark-grey-4);
 			}
 		}
+
+		th,
+		td {
+			border-color: var(--dark-grey) !important;
+		}
 	}
 
 	.table-header,
@@ -679,6 +671,8 @@ export default {
 					td {
 						border: 1px solid var(--light-grey-2);
 						border-width: 0 1px 1px 0;
+						white-space: nowrap;
+						text-overflow: ellipsis;
 
 						&:first-child,
 						&:last-child {