Browse Source

refactor(SortablePlaylists): no need for interval, vuedraggable has a 'change' event

Signed-off-by: Jonathan <theflametrooper@gmail.com>
Jonathan 4 years ago
parent
commit
e149d1ca48

+ 0 - 1
frontend/src/components/modals/EditPlaylist.vue

@@ -223,7 +223,6 @@ export default {
 		return {
 			utils,
 			drag: false,
-			interval: null,
 			playlist: { songs: [] },
 			songQueryResults: [],
 			searchSongQuery: "",

+ 0 - 5
frontend/src/mixins/SortablePlaylists.vue

@@ -8,7 +8,6 @@ export default {
 	data() {
 		return {
 			orderOfPlaylists: [],
-			interval: null,
 			drag: false
 		};
 	},
@@ -25,10 +24,6 @@ export default {
 			};
 		}
 	},
-	mounted() {
-		// checks if playlist order has changed every 1/2 second
-		this.interval = setInterval(() => this.savePlaylistOrder(), 500);
-	},
 	methods: {
 		calculatePlaylistOrder() {
 			const calculatedOrder = [];

+ 1 - 0
frontend/src/pages/Profile.vue

@@ -166,6 +166,7 @@
 							v-bind="dragOptions"
 							@start="drag = true"
 							@end="drag = false"
+							@change="savePlaylistOrder"
 						>
 							<transition-group
 								type="transition"

+ 1 - 4
frontend/src/pages/Station/components/Sidebar/MyPlaylists.vue

@@ -7,6 +7,7 @@
 			v-bind="dragOptions"
 			@start="drag = true"
 			@end="drag = false"
+			@change="savePlaylistOrder"
 		>
 			<transition-group
 				type="transition"
@@ -155,10 +156,6 @@ export default {
 			);
 		});
 	},
-	beforeDestroy() {
-		clearInterval(this.interval);
-		this.savePlaylistOrder();
-	},
 	methods: {
 		edit(id) {
 			this.editPlaylist(id);