Browse Source

fix: Eslint issues

Owen Diffey 1 year ago
parent
commit
f410f44bad

+ 2 - 2
backend/src/JobContext.ts

@@ -1,3 +1,4 @@
+import { forEachIn } from "@common/utils/forEachIn";
 import { SessionSchema } from "@/modules/DataModule/models/sessions/schema";
 import Job, { JobOptions } from "@/Job";
 import { Log } from "@/LogBook";
@@ -7,7 +8,6 @@ import { JobDerived } from "./types/JobDerived";
 import assertJobDerived from "./utils/assertJobDerived";
 import { GetModelPermissionsResult } from "./modules/DataModule/models/users/jobs/GetModelPermissions";
 import { GetPermissionsResult } from "./modules/DataModule/models/users/jobs/GetPermissions";
-import { forEachIn } from "@common/utils/forEachIn";
 
 const permissionRegex =
 	/^(?<moduleName>[a-z]+)\.(?<modelOrJobName>[A-z]+)\.(?<jobName>[A-z]+)(?:\.(?<modelId>[A-z0-9]{24}))?(?:\.(?<extra>[A-z]+))?$/;
@@ -131,7 +131,7 @@ export default class JobContext {
 	}
 
 	public async assertPermissions(permissions: string[]) {
-		let hasPermission: { [permission: string]: boolean } = {};
+		const hasPermission: { [permission: string]: boolean } = {};
 		permissions.forEach(permission => {
 			hasPermission[permission] = false;
 		});

+ 2 - 1
backend/src/modules/DataModule/DataModuleJob.ts

@@ -5,7 +5,8 @@ import { UserSchema } from "./models/users/schema";
 
 export default abstract class DataModuleJob extends Job {
 	protected static _modelName: string;
-	protected static _isBulk: boolean = false;
+
+	protected static _isBulk = false;
 
 	protected static _hasPermission:
 		| boolean

+ 2 - 2
backend/src/modules/DataModule/DeleteManyByIdJob.ts

@@ -3,7 +3,7 @@ import DataModule from "../DataModule";
 import DataModuleJob from "./DataModuleJob";
 
 export default abstract class FindManyByIdJob extends DataModuleJob {
-	protected static _isBulk: boolean = true;
+	protected static _isBulk = true;
 
 	protected override async _validate() {
 		if (typeof this._payload !== "object" || this._payload === null)
@@ -19,7 +19,7 @@ export default abstract class FindManyByIdJob extends DataModuleJob {
 	protected async _execute() {
 		const model = await DataModule.getModel(this.getModelName());
 
-		const _ids = this._payload._ids;
+		const { _ids } = this._payload;
 		const query = model.deleteMany({
 			_id: _ids
 		});

+ 2 - 2
backend/src/modules/DataModule/FindManyByIdJob.ts

@@ -3,7 +3,7 @@ import DataModule from "../DataModule";
 import DataModuleJob from "./DataModuleJob";
 
 export default abstract class FindManyByIdJob extends DataModuleJob {
-	protected static _isBulk: boolean = true;
+	protected static _isBulk = true;
 
 	protected override async _validate() {
 		if (typeof this._payload !== "object" || this._payload === null)
@@ -19,7 +19,7 @@ export default abstract class FindManyByIdJob extends DataModuleJob {
 	protected async _execute() {
 		const model = await DataModule.getModel(this.getModelName());
 
-		const _ids = this._payload._ids;
+		const { _ids } = this._payload;
 		const query = model.find({
 			_id: _ids
 		});