Add command line switch --no-updates to disable auto-updates.

src/main.cpp

@@ -12,6 +12,7 @@
 #include "shared/Names.h"
 #include "system/SystemComponent.h"
 #include "system/UpdateManager.h"
+#include "system/UpdaterComponent.h"
 #include "QsLog.h"
 #include "Paths.h"
 #include "player/CodecsComponent.h"
@@ -101,6 +102,7 @@ int main(int argc, char *argv[])
                        {"auto-layout",             "Use auto-layout mode"},
                        {"windowed",                "Start in windowed mode"},
                        {"fullscreen",              "Start in fullscreen"},
+                       {"no-updates",              "Disable auto-updating"},
                        {"terminal",                "Log to terminal"}});
 
     auto scaleOption = QCommandLineOption("scale-factor", "Set to a integer or default auto which controls" \
@@ -184,7 +186,7 @@ int main(int argc, char *argv[])
       Log::EnableTerminalOutput();
 
     // Quit app and apply update if we find one.
-    if (UpdateManager::CheckForUpdates())
+    if (!parser.isSet("no-updates") && UpdateManager::CheckForUpdates())
     {
       app.quit();
       return 0;
@@ -203,6 +205,9 @@ int main(int argc, char *argv[])
     //
     ComponentManager::Get().initialize();
 
+    if (parser.isSet("no-updates"))
+      UpdaterComponent::Get().disable();
+
     SettingsComponent::Get().setCommandLineValues(parser.optionNames());
 
     // enable remote inspection if we have the correct setting for it.

src/system/UpdaterComponent.cpp

@@ -29,11 +29,16 @@ using namespace qhttp::client;
 UpdaterComponent::UpdaterComponent(QObject* parent) :
   ComponentBase(parent),
   m_netManager(this),
-  m_checkReply(nullptr)
+  m_checkReply(nullptr),
+  m_enabled(true)
 {
   m_file = nullptr;
   m_manifest = nullptr;
 
+#ifdef NDEBUG
+  m_enabled = false;
+#endif
+
   connect(&m_netManager, &QNetworkAccessManager::finished, this, &UpdaterComponent::dlComplete);
 
   connect(&SystemComponent::Get(), &SystemComponent::userInfoChanged, [&](){
@@ -53,9 +58,8 @@ UpdaterComponent::UpdaterComponent(QObject* parent) :
 /////////////////////////////////////////////////////////////////////////////////////////
 void UpdaterComponent::checkForUpdate()
 {
-#if !defined(NDEBUG)
-  return;
-#endif
+  if (!m_enabled)
+    return;
 
   auto systemInfo = SystemComponent::Get().systemInformation();
   QUrl baseUrl = QString("https://plex.tv/updater/products/%0/check.xml").arg(systemInfo["productid"].toInt());

src/system/UpdaterComponent.h

@@ -142,6 +142,8 @@ public:
   const char* componentName() override { return "updater"; }
   bool componentInitialize() override { return true; }
 
+  Q_INVOKABLE void disable() { m_enabled = false; }
+
   // Disable old API for now
   Q_INVOKABLE void downloadUpdate(const QVariantMap &updateInfo) { };
 
@@ -182,6 +184,7 @@ private:
 
   QVariantHash m_updateInfo;
   QTime m_lastUpdateCheck;
+  bool m_enabled;
 };
 
 #endif // UPDATERCOMPONENT_H