Home Explore Help
Sign In
kris
/
jellyfin-media-player
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

installer: do not remove shortcuts when updating, fixes #425

Current installer will remove completely the previous installed version before installing the update
This results in breaking the pinned taskbar shortcuts at every update which is irritating for users.

That patch will skip the shortcuts removal. This will also skip the shortcut removal when completely uninstalling the app, but windows will propose to remove it next time you click it and that the app was uninstalled.

So this is improving current situation even if not perfect.
Lionel CHAZALLON 7 years ago
parent
f13a95a517
commit
f9fb10afa9
1 changed files with 1 additions and 0 deletions
Unified View Show Diff Stats
  1. 1 0
      bundle/win/PMP.wxs

+ 1 - 0
bundle/win/PMP.wxs
View File 

@@ -69,6 +69,7 @@
 
       <!-- Prevent downgrades from newer versions -->
 
       <!-- Prevent downgrades from newer versions -->
 
       <Custom Action="PreventDowngrades" After="FindRelatedProducts">NEWERPRODUCTFOUND</Custom>
 
       <Custom Action="PreventDowngrades" After="FindRelatedProducts">NEWERPRODUCTFOUND</Custom>
 
       <!-- Uninstall older versions before installing ourselves -->
 
       <!-- Uninstall older versions before installing ourselves -->
 
+      <RemoveShortcuts>Installed AND NOT UPGRADINGPRODUCTCODE</RemoveShortcuts>
 
       <RemoveExistingProducts After="InstallInitialize">PREVIOUSVERSIONINSTALLED</RemoveExistingProducts>
 
       <RemoveExistingProducts After="InstallInitialize">PREVIOUSVERSIONINSTALLED</RemoveExistingProducts>
 
       <Custom Action="LaunchPMP" After="InstallFinalize"><![CDATA[AUTOLAUNCH = 1]]></Custom>
 
       <Custom Action="LaunchPMP" After="InstallFinalize"><![CDATA[AUTOLAUNCH = 1]]></Custom>
 
       <Custom Action="WixCloseApplications" After="InstallInitialize" />
 
       <Custom Action="WixCloseApplications" After="InstallInitialize" />